[mythtv] [mythtv-commits] Ticket #8357: add xdg-screensaver support

[Robert McNamara]

On Fri, Apr 16, 2010 at 4:04 PM, MythTV <mythtv at cvs.mythtv.org> wrote:
> #8357: add xdg-screensaver support
> ---------------------------------------------------+------------------------
>  Reporter:  Johnny Walker <johnnyjboss@…>          |       Owner:  ijr
>     Type:  enhancement                            |      Status:  new
>  Priority:  minor                                  |   Milestone:  unknown
> Component:  MythTV - General                       |     Version:  0.23rc2
>  Severity:  low                                    |     Mlocked:  0
> ---------------------------------------------------+------------------------
>  these will detect the presence of xdg-screensaver (from the xdg-utils
>  package) and use it to suspend and resume the screensaver instead of the
>  existing xscreensaver-x11 support which involves timers and pokings.
>

Hi Johnny,

Just some miscellaneous stuff that may help you out:

* When you add new files, you can do "svn add filename" and then it'll
be a part of the diff.

* You are using tabs instead of spaces.  Our formatting standards call
for four spaces as the indent.

* Example code:

        if (result){
                VERBOSE(VB_GENERAL, "XDG: XDG-screensaver is supported.");
        }

In the above example, we would put the opening brace on the next line
like (also corrected indent):

        if (result)
        {
            VERBOSE(VB_GENERAL, "XDG: XDG-screensaver is supported.");
        }

* Example code:

                if (!d->IsScreenSaverRunning())
                        return;
                {
                        if (d->m_xdgscreensaverRunning)
                        {

This seems not to be what you mean, or at least is confusing
formatting.  Either the brackets and indent after the "return;" are
unnecessary, or you're missing an "else" (either of which will
accomplish the same thing).

* What's the purpose of ScreenSaverXDG::Reset(void) other than to
advertise 'House?'

* What's the purpose of ScreenSaverXDG::Asleep(void) just returning false?

Robert