[mythtv] [mythtv-commits] mythtv commit: r24081 by robertm

[Peter Stokes]

On 12 Apr 2010, at 06:05, mythtv at cvs.mythtv.org wrote:

>      Author: robertm
>        Date: 2010-04-12 05:05:57 +0000 (Mon, 12 Apr 2010)
> New Revision: 24081
>   Changeset: http://svn.mythtv.org/trac/changeset/24081
> 
> Modified:
> 
>   trunk/mythtv/libs/libmyth/mythcommandlineparser.h
> 
> Log:
> 
> Fix #8335.  Add include required for building on OS X since r24030.  If any of the Mac OS X devs see an issue with the location of the include or otherwise, please feel free to revert or correct.
> 



Hi Robert,

I fixed this locally using the patch below. As we're using a cross-platform framework, it's seems reasonable to exploit it wherever possible?

Peter


Index: libs/libmyth/mythcommandlineparser.cpp
===================================================================
--- libs/libmyth/mythcommandlineparser.cpp	(revision 24062)
+++ libs/libmyth/mythcommandlineparser.cpp	(working copy)
@@ -2,6 +2,7 @@
 using namespace std;
 
 #include <QFile>
+#include <QFileInfo>
 #include <QSize>
 
 #include "mythcommandlineparser.h"
@@ -55,7 +56,7 @@
 {
     err = false;
 
-    binname = basename(argv[0]);
+    binname = QFileInfo(argv[0]).baseName();
 
     if (argpos >= argc)
         return false;