[mythtv] [mythtv-commits] Ticket #8134: internal dvd player: fast dvd playback (not related to #7067)

[stanley kamithi]

janneg ...and.. anyone else who understand ffmpeg well.

I'd like to get your comments about the patch called
"ffmpeg_based_fix_for_8134.diff". I realized the calls to activate the
AFD::HandleStreamChange are not part of the mainline ffmpeg. This patch
makes a few changes to one of these calls. It activates handlestreamchange
for audio streams only after checks on the audio matching pcm_dvd codec type
. this resolves the issue for this ticket. When I play a dvd with this
patch, It correctly discovers the stream as PCM_S16BE with 2 channels
instead of PCM_DVD with 0 channels. I've done some light testing and regular
recordings I have, both video and recorded shows play fine. stream discovery
issues occur with dvds cause it doesn't use av_find_stream_info to discover
streams. if it did, then there won't be a stream discovery issue.

problem with av_find_stream_info is that it discards quite a few packets and
if these are still frames then it affects dvd menu navigation. I've not
found any way to use av_stream_find_info for stream discovery and still get
dvd menu navigation to function correctly. The best thing I've found is
relying on the stream discovery in libavformat/mpeg.c mpegps_read_packet.
MP2 audio streams in dvds have the same discovery problem. this is under
#8260. No sample rate is set in this case. I'm running quite a few debugs to
figure out why. I hope i've made sense. Thx in advance for your comments.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mythtv.org/pipermail/mythtv-dev/attachments/20100408/6b1f47f1/attachment.htm>