[mythtv] [mythtv-commits] Ticket #6711: Update win32-packager.pl to use Qt4 binary dist

[buzz]

>
> > 4) there is a 'sleep 5' that was in there
> > deliberately, because windows FAT filesystems have an inode
> > timestamp accuracy of 2 seconds, and without the 'sleep
> > 5', the incorrect logic can be triggered in some unusual
> > circumstances, I think it's safer to put it back in.
>
> In the original script, the 'sleep 5' was placed after the 'touch -r', so
> how could it have any affect on the timestamp?  Besides, does anyone
> actually use FAT for their system partition these days?  I don't think
> that's even possible with Vista.


I think there was another file created further down in the script ( in the
same way), which was compared against this one, and it was then that the
script was bailing out... yes, the "one second" error sounds like the one
that I encountered before, but it's been a while since I wrote it.  :-)

>
> I replaced the 'cat, touch, sleep' sequence because in my experience, it
> has been very unreliable (on NTFS anyway).  MSYS's 'touch -r' is buggy and
> often leaves the two files' timestamps differing by 1 second.  The script
> often halted at that step because the filesame comparison failed.  In my
> testing, MSYS's 'cp -p' copies the timestamp exactly, so that's what I put
> in the patch.


Ok, looks great then!

>
>
> > Otherwise the patch looks great!  ( not having tried it though)
>
> Thanks.  I have run the script from scratch (no existing mingw, msys,
> mythtv directories, etc.), so rest assured the changes are tested.
>
> Cheers,
> Jeff
>
>
>
> _______________________________________________
> mythtv-dev mailing list
> mythtv-dev at mythtv.org
> http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mythtv.org/pipermail/mythtv-dev/attachments/20090712/ce0c65ec/attachment.htm>