[mythtv] [mythtv-commits] Ticket #6711: Update win32-packager.pl to use Qt4 binary dist

buzz davidbuzz at gmail.com
Sat Jul 11 12:56:34 UTC 2009

Hey Jeff,

...just reviewing the changes in this patch and got a couple questions:

1) why'd you remove the bit that downloads/extracts the pthreads dlls?
2) you've removed 3 of the 5 source patches required in QT4, but left-in
another two.... how are they being used if the QT is now coming direct from
binaries?   So qobjectdefs.h, generator.cpp, and qatomic_windows.h are no
longer being patched , but option.cpp and qmake.conf  are OK  to patch?
I'm confused what the reasoning is here?
3) you're still using the QT sources to build the sql drivers... where are
they downloaded from ( are they inside the binary distribution package)?
4) there is a 'sleep 5' that was in there deliberately, because windows FAT
filesystems have an inode timestamp accuracy of 2 seconds, and without the
'sleep 5', the incorrect logic can be triggered in some unusual
circumstances, I think it's safer to put it back in.

Otherwise the patch looks great!  ( not having tried it though)


On Sat, Jul 11, 2009 at 4:49 AM, MythTV <mythtv at cvs.mythtv.org> wrote:

> #6711: Update win32-packager.pl to use Qt4 binary dist
> ----------------------------------------+-----------------------------------
>  Reporter:  Jeff Lu <jll544 at yahoo.com>  |       Owner:  nigel
>     Type:  patch                       |      Status:  new
>  Priority:  minor                       |   Milestone:  unknown
> Component:  Ports - Windows             |     Version:  head
>  Severity:  medium                      |     Mlocked:  0
> ----------------------------------------+-----------------------------------
>  Update to the win32 packager script attached, with the major change of
>  using Trolltech Qt4.5 binaries instead of compiling from source, thereby
>  cutting overall build time by a few hours and hopefully reducing user-
>  reported problems.
>  Other changes: update gcc to 4.2.4 to appease ffmpeg, update source
>  download locations/versions, default compile_type to profile for better
>  performance, default cpu_arch to p4 for wider compatibility and fewer
>  user-reported crashes, fix libvisual and SDL installs for potential plugin
>  porting.
>  Tested with trunk r20847 on XP and Vista 32bit.
> --
> Ticket URL: <http://svn.mythtv.org/trac/ticket/6711>
> MythTV <http://www.mythtv.org/>
> MythTV
> _______________________________________________
> mythtv-commits mailing list
> mythtv-commits at mythtv.org
> http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mythtv.org/pipermail/mythtv-dev/attachments/20090711/df58631c/attachment.htm>

More information about the mythtv-dev mailing list