[mythtv] [mythtv-commits] Ticket #3664: mythrename.pl dies if filetype is not mpeg

Michael T. Dean mtdean at thirdcontact.com
Sun Mar 9 23:43:11 UTC 2008


On 03/09/2008 06:40 PM, MythTV wrote:
> #3664: mythrename.pl dies if filetype is not mpeg
>
>
> Comment(by Roo):
>
>  Replying to [comment:4 kormoc]:
>  > I believe that this shouldn't be an issue with the script anymore, can
>  you confirm Roo?
>
>  Unfortunately I can not test as I don't have the original file anymore. It
>  was always a strange one as it was a recording that was made by Myth but
>  reported as a nsv.
>
>  I was able to run mythrename.pl on the recordings I do have.

It definitely should not be a problem in mythrename.pl, anymore, as 
mythrename.pl no longer calls load_file_info().  Anyone who does 
recordings of DVB Radio (or at least DVB radio in the UK) should be able 
to verify it's fixed (see 
http://www.gossamer-threads.com/lists/mythtv/users/312953#312953 ).

However, there's still an issue in load_file_info() in Recording.pm.  It 
would be nice to fix it to better handle, i.e. DVB radio recordings.

That said, I'd say it's probably better to spend the effort on creating 
the backend support for determining/storing this information, instead.  
Since we now have "a while" until the next release version (0.22), we'll 
have a chance to get a real solution in place to allow replacing the 
workaround Chris had to use.  And, since none of the contrib scripts use 
load_file_info(), anymore, "fixing" load_file_info isn't that important.

I recommend marking the ticket as closed/fixed (by [16106]) as the issue 
in the ticket is fixed.  Then, if we don't have backend support for 
determining/storing file information (i.e. in the recordedfile table) by 
the time we do a 0.22 release, we can consider improving the mplayer 
output parsing.

Mike


More information about the mythtv-dev mailing list