[mythtv] [mythtv-commits] Ticket #4536: Recording appears in Watch Recordings too early

Chris Pinkham cpinkham at bc2va.org
Tue Jan 29 01:46:33 UTC 2008


* On Mon Jan 28, 2008 at 06:17:35PM -0500, Mark Buechler wrote:
> > if (rec->availableStatus == asNotYetAvailable)
> > {
> >     ProgramInfo *tmpItem = findMatchingProg(rec);
> >     if (tmpItem)
> >         tmpItem->availableStatus = asAvailable;
> > }

> Yes, that patch doesn't fix it entirely. However, would setting
> availableStatus to asAvailable before those checks have the same effect?
> 
> ProgramInfo *tmpItem = findMatchingProg(rec);
> if (tmpItem && (tmpItem->availableStatus == asNotYetAvailable))
>     tmpItem->availableStatus = asAvailable;
> 
> if (fileExists(rec) == false)
> {
>     QString msg =

Yes, you can put the new check at the top, but please format it like I did
above.  There's no need to cycle through the whole in-memory recording
list trying to find the current record if we don't need to modify
the availableStatus.

--
Chris


More information about the mythtv-dev mailing list