[mythtv] [mythtv-commits] Ticket #4536: Recording appears in Watch Recordings too early

Chris Pinkham cpinkham at bc2va.org
Mon Jan 28 19:17:03 UTC 2008


* On Mon Jan 28, 2008 at 06:26:04PM -0000, MythTV wrote:
> #4536: Recording appears in Watch Recordings too early

> Changes (by otto at kolsi dot fi):
> 
>  Daniel, I have to disagree. If there would be new coloring scheme or delay
>  functionality, that would be new feature (I wasn't actually asking these).
>  But if we discard those new ideas, I see two definite bugs currently:
> 
>   * when frontend reports that recording file is empty, if you move cursor
>  away from that recording the color indicating ongoing recording disappears
>   * once the bug has appeared, you can wait 5min or 30min in Watch
>  recordings screen and frontend '''never''' allows you to watch the
>  recording. Frontend does not recover from this problem (not even when next
>  recording is added to the list of recordings). I think it would be okay if
>  e.g. 15sec or even 30sec later file could be watched (when enough data is
>  in disk and in DB) without re-entering Watch Recordings screen.

Both of these could be fixed in one line of code if you test and submit a
patch.

Edit programs/mythfrontend/playbackbox.cpp and search for PlaybackBox::play.

Find the following section:

        ProgramInfo *tmpItem = findMatchingProg(rec);
        if (tmpItem)
        {
            tmpItem->availableStatus = asFileNotFound;
            showAvailablePopup(tmpItem);
        }

Change that "if (tmpItem)" to this:

	    if (tmpItem && (tmpItem->recstartts < QDateTime::currentDateTime().addSecs(-15)))

That will modify it so that we don't mark a file as "not found" until 15 seconds after
the recording started.  That should be enough to fix your issue....

If that works, then upload the patch to trac and someone will commit it.

--
Chris


More information about the mythtv-dev mailing list