[mythtv] [mythtv-commits] Ticket #4536: Recording appears in Watch Recordings too early

Mark Buechler mark.buechler at gmail.com
Mon Jan 28 19:37:17 UTC 2008


Would the attached patch work better?

- Mark.

On 1/28/08, Chris Pinkham <cpinkham at bc2va.org> wrote:
>
> * On Mon Jan 28, 2008 at 06:26:04PM -0000, MythTV wrote:
> > #4536: Recording appears in Watch Recordings too early
>
> > Changes (by otto at kolsi dot fi):
> >
> >  Daniel, I have to disagree. If there would be new coloring scheme or
> delay
> >  functionality, that would be new feature (I wasn't actually asking
> these).
> >  But if we discard those new ideas, I see two definite bugs currently:
> >
> >   * when frontend reports that recording file is empty, if you move
> cursor
> >  away from that recording the color indicating ongoing recording
> disappears
> >   * once the bug has appeared, you can wait 5min or 30min in Watch
> >  recordings screen and frontend '''never''' allows you to watch the
> >  recording. Frontend does not recover from this problem (not even when
> next
> >  recording is added to the list of recordings). I think it would be okay
> if
> >  e.g. 15sec or even 30sec later file could be watched (when enough data
> is
> >  in disk and in DB) without re-entering Watch Recordings screen.
>
> Both of these could be fixed in one line of code if you test and submit a
> patch.
>
> Edit programs/mythfrontend/playbackbox.cpp and search for
> PlaybackBox::play.
>
> Find the following section:
>
>         ProgramInfo *tmpItem = findMatchingProg(rec);
>         if (tmpItem)
>         {
>             tmpItem->availableStatus = asFileNotFound;
>             showAvailablePopup(tmpItem);
>         }
>
> Change that "if (tmpItem)" to this:
>
>             if (tmpItem && (tmpItem->recstartts <
> QDateTime::currentDateTime().addSecs(-15)))
>
> That will modify it so that we don't mark a file as "not found" until 15
> seconds after
> the recording started.  That should be enough to fix your issue....
>
> If that works, then upload the patch to trac and someone will commit it.
>
> --
> Chris
> _______________________________________________
> mythtv-dev mailing list
> mythtv-dev at mythtv.org
> http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mythtv.org/pipermail/mythtv-dev/attachments/20080128/22b6a049/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: text/x-diff
Size: 2233 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20080128/22b6a049/attachment.bin 


More information about the mythtv-dev mailing list