[mythtv] [mythtv-commits] Ticket #4670: If buffer alloc fails, dvd file should be closed

Stuart Morgan stuart at tase.co.uk
Thu Feb 14 19:36:32 UTC 2008

On Thursday 14 February 2008 19:23:06 MythTV wrote:
> #4670: If buffer alloc fails, dvd file should be closed
> ---------------------------------------------+-----------------------------
>- Reporter:  Erik Hovland <erik at hovland.org>  |       Owner:  ijr
>      Type:  patch                            |      Status:  new
>  Priority:  minor                            |   Milestone:  0.21
> Component:  mythtv                           |     Version:  head
>  Severity:  low                              |     Mlocked:  0
> ---------------------------------------------+-----------------------------
>- In the function DVDDiscID, in the file dvd_reader.c, in libmythdvdnav the
> function allocates a buffer to store some disc id information. If that
> allocation fails the function returns but the dvd file is still open. Which
> means that both the dvd file struct and the file handle associated to that
> dvd file are leaked.

Eric are you sending any of these fixes upstream? I don't know if libdvdnav 
has a maintainer these days but just thought I'd ask.

Stuart Morgan

More information about the mythtv-dev mailing list