[mythtv] Ticket #3963: [PATCH] Use DTVRecorder::Reset() instead of derived class' Reset()

Daniel Kristjansson danielk at cuymedia.net
Wed Sep 19 15:53:27 UTC 2007


On Wed, 2007-09-19 at 11:19 -0400, Shane wrote:
> On 9/18/07, Daniel Kristjansson <danielk at cuymedia.net> wrote:
> ...
> > > NVR/mpeg recorders:
> > >
> > > ResetForNewFile() ->
> > >     reset some variables
> > >     positionMap.clear()
> > >     positionMapDelta.clear()
> >
> > This is what we should be doing.
> 
> Ok
> 
> > I think the reason we don't do the reset this way in the DVB recorder
> > is because it doesn't have a functional Pause()/Unpause() like the NVR
> > does. But we I believe I fixed this in the multirec branch, so the
> > NVR ResetForNewFile() method would be safe with the DVB recorder in
> > the multirec branch.
> 
> Ok, cool. Here is a patch for multirec that implements
> ResetForNewFile() for dvbrecorders. Attempts to be like NVR. :)
> 
> Seems to behave pretty well here in quick testing.

I made a little change to this and attached the patch to the ticket.
I want to address all the DTVRecorder based recorders, not just
DVBRecorder in the fix. It's not tested, but in theory should work.

-- Daniel



More information about the mythtv-dev mailing list