[mythtv] Ticket #3963: [PATCH] Use DTVRecorder::Reset() instead of derived class' Reset()

Shane gnome42 at gmail.com
Wed Sep 19 15:19:30 UTC 2007


On 9/18/07, Daniel Kristjansson <danielk at cuymedia.net> wrote:
...
> > NVR/mpeg recorders:
> >
> > ResetForNewFile() ->
> >     reset some variables
> >     positionMap.clear()
> >     positionMapDelta.clear()
>
> This is what we should be doing.

Ok

> I think the reason we don't do the reset this way in the DVB recorder
> is because it doesn't have a functional Pause()/Unpause() like the NVR
> does. But we I believe I fixed this in the multirec branch, so the
> NVR ResetForNewFile() method would be safe with the DVB recorder in
> the multirec branch.

Ok, cool. Here is a patch for multirec that implements
ResetForNewFile() for dvbrecorders. Attempts to be like NVR. :)

Seems to behave pretty well here in quick testing.

Shane
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mythtv_multirec_dvbrec_ResetForNewFile.diff
Type: plain/text
Size: 1127 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20070919/e02f07b3/attachment.bin 


More information about the mythtv-dev mailing list