[mythtv] [mythtv-commits] Ticket #4132: In some menu's ESCAPE action is not handled appropriately
danielk at cuymedia.net
Tue Nov 20 15:54:22 UTC 2007
On Tue, 2007-11-20 at 10:26 +0000, Matthew Wire wrote:
> Following commit 14908 I've been updated some patches for the new dialog
> code. This made me notice some inconsistency in the method names.
> Normally, it would cause too much breakage to change these, however
> since 14908 already breaks third-party plugins etc. I think it would be
> worth changing all these to lower case for consistency.
Actually leading upper would be the MythTV style. But all these dialogs
are on their way out in favor of mythui versions so it seems silly to
spend a lot of time correcting stylistic issues. Since these classes
have public Qt parent classes it would require a lot of testing if
we went around renaming methods wholesale. In fact making those parent
classes private would be a much better use of someones time. But these
are all depreciated in favor of the MythUI classes, the only reason I
spent a considerable time on them is because they were broken and when
I started fixing this problem some months ago it seemed easier to fix
the existing classes than to move everything to the new ones.
More information about the mythtv-dev