[mythtv] [mythtv-commits] Ticket #4132: In some menu's ESCAPE action is not handled appropriately

Matthew Wire devel at mrwire.co.uk
Tue Nov 20 10:26:26 UTC 2007


Following commit 14908 I've been updated some patches for the new dialog
code.  This made me notice some inconsistency in the method names.

addWidget
addLayout
addLabel
addButton
ShowPopup
ShowPopupAtXY
ExecPopup
ExecPopupAtXY
showOkPopup
showOkCancelPopup
Show2ButtonPopup
ShowButtonPopup
showGetTextPopup
showPasswordPopup
AcceptItem
accept
reject
popupDone
~MythPopupBox
focusNextPrevChild
keyPressEvent
defaultButtonPressedHandler

Most of the methods use a small letter at the start but some use a
capital: ShowPopup, ShowPopupAtXY, ExecPopup, ExecPopupAtXY,
Show2ButtonPopup, ShowButtonPopup.
Normally, it would cause too much breakage to change these, however
since 14908 already breaks third-party plugins etc. I think it would be
worth changing all these to lower case for consistency.

Paul/Daniel - What do you think?
I will do the work required, I just need to know it's worth doing first
so I don't waste my time.

Matthew



More information about the mythtv-dev mailing list