[mythtv] MythGame PC game scanning bug?

[Marc Alban]

Someone on the users mailing list mentioned that they could not get PC 
games to work with MythGame.  I followed the instructions provided by 
other users and on the wiki, but I was also was unable to get PC games 
to be recognized by the system (20-fixes).  I looked at the current SVN 
code and I think I found the problem.  There appears to be some typos 
that render the scanning for the "PC" game type useless.

    if (handler->GameType() == "PC")
    {
        thequery = QString("INSERT INTO gamemetadata "
                           "(system, romname, gamename, genre, year, 
gametype, country, "
                           "diskcount, display, publisher, version) "
                           "VALUES ('%1', '%2', '%3', 'UnknownPC', 
'19xx' , '%4', "
                           "'Unknown',1,1,'Unknown', '0');")
                           .arg(handler->SystemName())
                           .arg(handler->SystemName())
                           .arg(handler->SystemName())
                           .arg(handler->GameType());

1 - It looks to me like %2 should be the executable name, not the name of 
the game player which would just be "PC-GAMES".  This would be the main 
problem.
2 - It looks like %3 should be "PC" not the name of the game player
3 - It looks like the rom path is missing.  Maybe %2 will contain the full path of the rom and this is not needed?

I can create a ticket for this if this is a reasonable conclusion.

Marc