[mythtv] [mythtv-commits] Ticket #3788: instead of deleting a show, mark it for auto-expire and put in a "deleted" group

Chris Pinkham cpinkham at bc2va.org
Fri Aug 3 18:15:28 UTC 2007

* On Fri Aug 03, 2007 at 08:24:53PM +1000, Roo wrote:
> > When you undelete, you should reset the autoexpire value on the
> > recording to whatever the default for that recording was (based on
> > recordid), but I wonder if you should just force autoeexpire to 0 in
> > this case.  If I'm undeleting something, I probably don't want it to
> > be auto-expired.  That may be too much assumption though.
> It seems the autoexpire is an int(11) but is currently only using
> values >= 0, maybe we could extend the autoexpire / delayed delete to
> make use of the full range.

It uses positive values because 0 is 'don't expire' and anything greater
than 0 is sorted and expired in highest-value first order.  Using negative
numbers wouldn't allow this and there's enough room in the int(11) to
be quite flexible.

We might want to make the value for 'deleted' programs to be something
like 9000 to allow people to setup their own values between 9000 and
the 10000 we use for LiveTV.

> IIRC, there has been some discussion about allowing the user to set an
> integer autoexpire value in the recording rule. Using the negative
> range as above would work with these change, if someone made them.

Yes, this is the reasoning behind leaving it at 9000 or so instead of
the 9999 I mentioned in my previous email.

Allowing the user to set this value is a fairly easy change to make
to the scheduled recording editor, but there are other places in the
code that currently assume 0 or 1 that may need to be changed if we
wanted the user to be able to turn auto-expire off then later back on
while preserving the original autoexpire value.  With the current
default of '1' meaning 'On', then things you turned back on would be
expired after everything that was set for autoexpire that had a higher
untouched original value.


More information about the mythtv-dev mailing list