[mythtv] [PATCH] mythtranscode: don't segfault when no proginfo

Brendan Cully brendan at kublai.com
Sat Feb 11 02:29:04 UTC 2006


Hi,

I've been running mythtranscode by hand and it seems to segfault after
transcoding when m_proginfo is NULL. Since this is allowed earlier in
the code, I guess the attached guard is probably warranted?

Brendan
-------------- next part --------------
diff -r 1c6a4b39b5e1 programs/mythtranscode/transcode.cpp
--- a/programs/mythtranscode/transcode.cpp	Fri Feb 10 06:03:03 2006 +0000
+++ b/programs/mythtranscode/transcode.cpp	Fri Feb 10 18:21:47 2006 -0800
@@ -807,9 +807,12 @@ int Transcode::TranscodeFile(char *input
 
     if (! fifow)
     {
-        m_proginfo->ClearPositionMap(MARK_KEYFRAME);
-        m_proginfo->ClearPositionMap(MARK_GOP_START);
-        m_proginfo->ClearPositionMap(MARK_GOP_BYFRAME);
+    	if (m_proginfo)
+    	{
+            m_proginfo->ClearPositionMap(MARK_KEYFRAME);
+            m_proginfo->ClearPositionMap(MARK_GOP_START);
+            m_proginfo->ClearPositionMap(MARK_GOP_BYFRAME);
+    	}
 
         nvr->WriteSeekTable();
         if (!kfa_table->isEmpty())


More information about the mythtv-dev mailing list