[mythtv] [PATCH] Remove use of deprecated DVB events.

Allan Stirling Dibblahmythml0015 at pendor.org
Thu Sep 1 21:40:28 UTC 2005


Mark Weaver wrote:
> Kenneth Aafl°y wrote:
> 
>> torsdag 01 september 2005, 19:38, skrev Mark Weaver:
>>
>>> 1. Some cards report the actual locked on frequency in the status rather
>>> than the requested frequency.  We don't test the frequency, just the
>>> lock status, so this should be OK.
>>
>>
>>
>> AFAIK both events and FE_GET_FRONTEND should return the real parameters
>> of the frontend.
> 
> 
> This is what I was referring to:
> 
> ------------------------------------------------------------------------
> r7161 | danielk | 2005-08-28 23:57:25 +0100 (Sun, 28 Aug 2005) | 11 lines
> 
> Fixes channel changing problem for Torbjorn Jansson.
> 
> The problem was that his driver returns the actual center
> frequency the hardware locked onto instead of the one we
> tuned to. This is a neat feature, but we were only checking
> for an exact match in frequency for when to not wait for a
> DVB tuning event. With this commit any frequency within a
> range -500kHz to +500kHz is considered equal as far as DVB
> tuning events are concerned.
> 
> I'm not sure what you mean by 'real parameters', but apparently 
> sometimes the reported frequency is not the one you asked for.

I believe he may be referring to "real parameters" as the frequency 
(specifically, in this case) which the DVB card has, due to zig-zag 
tuning or LNB compensation found the signal to be best at.

The original commit worked around this in a rather hard-to-read format. 
The last patch I posted cleaned up this code somewhat, but didn't 
actually fix the other problems with the tuning code.

The patches that have been posted recently seem to completely remove the 
code that checks for an inexact (or even exact?) match between the 
frequency requested and the frontend currently tuned parameters.

Cheers,

Allan.


More information about the mythtv-dev mailing list