[mythtv] [PATCH] mythgame seg fault with custom levels

[Barney Barumba]

Hi,

I've just put together a long planned box with MythTV 0.17, and firstly
I'd just like to say thanks to all the people that put this software
together - it really is pretty cool to see it all coming together on the
TV.

Anyway, I've found (what looks like) a bug in the Mythgame interface - if
I remove "system" from the game tree levels (I only have one system right
now so don't really want to bother selecting it) then I get a seg fault
when trying to load the game data. So I had a hack about, and come up with
a patch that seems to solve the problem (attached).

Well, nearly! It appears to work fine for any game level setting that has
more than one level ("year genre gamename", or just "genre gamename"), but
when I bring it down to a single level of "gamename" I cannot get it to
activate the game. The list displays ok (possibly not colouring in the
game nodes correctly) but selecting a node has no effect. The
keyPressEvent method is called, with an action of "SELECT", but the
handleTreeListSelection method does not appear to fire.

The reason I want to run with one level is that, with favourites selected,
I only have a dozen or so games, and so a single display of gamename would
be sufficient.

If anybody has any ideas as to why this is, I'd love to know. I've never
programmed with the QT library stuff, so I'm poking around in the dark a
bit here.

The patch I've attached is against v0.17 - if I can get it working, and
people think it's useful, I'll download the latest cvs and update tha
patch for that code.

Moving on from here, what I would like is to remove the "ShowFavourites"
check box, and replace it with a separate "Favourite Tree Levels" setting
- so you could specify "system year genre gamename" for all games, but
only "gamename" for games tagged as favourites. At the top level I would
have "All Games" and "Favourites" leading to the two separate trees. This
would avoid having to switch out of the game list and into the settings to
turn favourites on and off.

Does anyone have any thoughts on this? I'm quite happy to give it a go,
but it would be a bit of a learning curve so I don't really want to get
into it if the consensus is that it's not a good idea.

Cheers,

Barney



-------------- next part --------------
A non-text attachment was scrubbed...
Name: mythgame-fix-levels.diff
Type: application/octet-stream
Size: 3259 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20050302/5b572f7f/mythgame-fix-levels.obj