[mythtv] [PATCH] Fix autoexpire bugs,
special display of suggestions
J. Donavan Stanley
jdonavan at jdonavan.net
Sat Jun 4 13:55:53 UTC 2005
Brad Templeton wrote:
>On Fri, Jun 03, 2005 at 02:58:34PM -0400, J. Donavan Stanley wrote:
>>Why overload the auto expire instead of just adding a bool to the
>My sense was that there could be a number of reasons for tagging
>recordings into high auto-expire classes, and all (or any) of them would
>merit some sort of special display for the items.
>Tivo, as you may know, puts a different icon next to its suggestions (it
>has icons in its program list) and also lists them always at the bottom
>of its lists.
Theres certainly usefulness in tagging recordings with the high auto
expire. My only concern is that we not overload the field is such a way
so as to make it mean something extra based on it's value. If all
reccommendations have a expiration of 100 (for example) so that they get
expired first that's fine. If they all have a value of 100 so they
expire first AND the system uses the value of 100 to present them as
reccommendations that's a bad thing as it forces two things 1) that
value (or range) can never be used for anything else and 2)
reccommendations must always use that value (or range) for auto expire.
>Also less familiarity with the code. Could you outline for me (and
>probably others would appreciate it as well) the ramifications of
>adding a field to these various tables (boolean or otherwise?) and
>thus also adding it to ProgramInfo? Because ProgramInfo is serialized
>over the myth protocol out to clients, does that mean you are changing
>the protocol to change this? Can you point me to protocol docs?
It's not a huge deal but there are several places you'd need to change
things.. The queries that read a programinfo from the db obviously, the
copy constructor, the send / receive string list for the programinfo,
mythweb's program info code and a bump of the protocol version. The
only protocol doc I can point you to is in mainserver.cpp not that that
helps a whole lot. But the protocol is pretty simple.
More information about the mythtv-dev