[mythtv] [PATCH] Fix autoexpire bugs,
special display of suggestions
brad+mydev at templetons.com
Fri Jun 3 20:32:50 UTC 2005
On Fri, Jun 03, 2005 at 02:58:34PM -0400, J. Donavan Stanley wrote:
> Brad Templeton wrote:
> >b) Code is added so that recordings with autoexpire >= 100 are flagged
> >with a different font on display in the list of current recordings.
> >Autoexpire >= 100 is a sign of special "suggestion" recordings (and
> >possibly other recordings scheduled for quick deletion)
> Why overload the auto expire instead of just adding a bool to the
> recorded table?
My sense was that there could be a number of reasons for tagging
recordings into high auto-expire classes, and all (or any) of them would
merit some sort of special display for the items.
Tivo, as you may know, puts a different icon next to its suggestions (it
has icons in its program list) and also lists them always at the bottom
of its lists.
Other uses for high autoexpire include undoable delete, and just plain
less important shows. In addition, there are multiple types of suggestions,
including algorithmic ones like these, and ones based on explicit and
implicit recommendations downloaded from others.
Also less familiarity with the code. Could you outline for me (and
probably others would appreciate it as well) the ramifications of
adding a field to these various tables (boolean or otherwise?) and
thus also adding it to ProgramInfo? Because ProgramInfo is serialized
over the myth protocol out to clients, does that mean you are changing
the protocol to change this? Can you point me to protocol docs?
This is a field that would be set in the record table, then stored in
the recorded table, and remembered in the oldrecorded table, and possibly
the new recordedprogram table whose purpose seems to still be being fleshed
(Remembering in oldrecorded is useful both for display and also to tell
the system not to train itself on prior suggestions, which gets too circular.
However, I also generate a new table 'suggestions' which serves this
purpose in any event so this is not as important. You need that table
to both avoid re-suggesting things that didn't get into oldrecorded because
they expired, and to downgrade recently suggested shows, which is one of
If we want to do an alternate encoding of a suggestion (which is fine by
me) the other part of the patch, which fixes the bug over copying autoexpire
from record to recorded should still be applied.
Note suggestions are also given their own recording group. One idea to
generalize the question of different sources of recordings would be to
add a database field so that things like recording groups and recording
classes could add optional font-changes or icons for display.
Of course you don't want an arbitrary list of icons, and you can't have
two fonts/colours at once so you don't get to be totally general.
More information about the mythtv-dev