[mythtv] [PATCH] Fix mythfrontend segmentation fault(s) and hangs

Mike Isely isely at isely.net
Sat Jan 8 23:33:09 EST 2005


The attached 2-line patch initializes previously uninitialized
"actuallypaused"  and "video_actually_paused" members in the
NuppelVideoPlayer constructor.

Not initializing "actuallypaused" definitely may lead to a segmentation
fault crash in mythfrontend when changing channels.  It can also cause the
front end to hang when trying to exit the pause state.  The line of
reasoning that explains these problems is lengthy and twisted, but I've
conclusively found that to be the case on my test system here.  I don't
understand why more people haven't been getting burned by this problem,
but it totally prevented me from using mythtv on one system.  I guess this
is a good thing because it forced me to learn a lot about mythtv's video
playback pathway.

The full explanation can be found in bugzilla entry #181 which can be
found here:

    http://www.mythtv.org/bugs/show_bug.cgi?id=181

The patch is attached to this message, and is also filed as an attachment
to the bug record.  I've marked the bug as resolved.

  -Mike


-- 
                        |         Mike Isely          |     PGP fingerprint
     Spammers Die!!     |                             | 03 54 43 4D 75 E5 CC 92
                        |   isely @ pobox (dot) com   | 71 16 01 E2 B5 F5 C1 E8
                        |                             |
-------------- next part --------------
Index: libs/libmythtv/NuppelVideoPlayer.cpp
===================================================================
RCS file: /var/lib/mythcvs/mythtv/libs/libmythtv/NuppelVideoPlayer.cpp,v
retrieving revision 1.408
diff -u -r1.408 NuppelVideoPlayer.cpp
--- libs/libmythtv/NuppelVideoPlayer.cpp	8 Jan 2005 16:48:12 -0000	1.408
+++ libs/libmythtv/NuppelVideoPlayer.cpp	9 Jan 2005 04:19:27 -0000
@@ -113,6 +113,8 @@
     nvr_enc = NULL;
 
     paused = false;
+    actuallypaused = false;
+    video_actually_paused = false;
 
     audiodevice = "/dev/dsp";
     audioOutput = NULL;


More information about the mythtv-dev mailing list