[mythtv] Re: Re: 0.17 playback on PVR-350 tvout has bad framecount timing

David Engel gigem at comcast.net
Wed Feb 16 19:29:37 UTC 2005

On Wed, Feb 16, 2005 at 12:05:19PM -0500, Derek Atkins wrote:
> David Engel <gigem at comcast.net> writes:
> > I'm the culprit.  When I reworked the buffering for ff/rew, it was
> > possible for the reference to be outside the buffer, so I commented it
> > out and forgot to go back and fix it.
> Um, so, how could the pointer be outside the buffer?  I guess this
> code could fail is if bufptr is pointing to the absolute end of the
> buffer, buf + len - 1, but I don't see any other time that the
> reference could be outside the buffer.

That's the case.  If it can happen, it will happen.

> > I know ID::ReadWrite is a mess, but could you try to do a full fix for
> > this?  If not, I'll try to get to it in the next couple of days.
> What does a "full fix" imply?  I'm not even sure I know what it means.

Adjusting the buffering to make sure the extra bytes will always be in
the buffer when needed.

David Engel
gigem at comcast.net

More information about the mythtv-dev mailing list