[mythtv] [PATCH]pvr-350 performance patch

[John Harvey]

Isaac
	Any news on what I need to do to this patch before you commit it?

Thanks

John

> -----Original Message-----
> From: mythtv-dev-bounces at mythtv.org [mailto:mythtv-dev-bounces at mythtv.org]
> On Behalf Of John Harvey
> Sent: 21 January 2005 21:57
> To: 'Development of mythtv'
> Subject: RE: [mythtv] [PATCH]pvr-350 performance patch
> 
> Isaac
> 	I had a quick look and I assume by existing region code you mean
> QT's QRegion ?
> 	The difference is that I turn the rects into a plain array
> effectively  so that 2 boxes beside each other get turned into one region
> even if they don't overlap on the screen.
> This is because currently the ivtv interface takes a start address and
> length so I cant give it smaller rectangular regions.
> 	I then merge these into a number of disjoint regions making sure the
> addresses etc. are aligned.
> 
> I think this is different from the region stuff elsewhere. Eventually I
> want
> to change ivtv to take rectangular regions and then the QT region stuff
> will
> be more appropriate.
> 
> Let me know if I've missed something though and I'll rework it.
> 
> John
> 
> > -----Original Message-----
> > From: mythtv-dev-bounces at mythtv.org [mailto:mythtv-dev-
> bounces at mythtv.org]
> > On Behalf Of John Harvey
> > Sent: 21 January 2005 08:58
> > To: Development of mythtv
> > Subject: Re: [mythtv] [PATCH]pvr-350 performance patch
> >
> > Probably because i didnt find it.
> > Can you point me in the right direction and i'll take
> > a look again.
> >
> > >From memory this does use most of the region code but
> > passes the information out so the ivtv driver can use
> > it since the regions werent available internally.
> >
> > John
> >  --- Isaac Richards <ijr at case.edu> wrote:
> > > On Sunday 09 January 2005 04:52 pm, John Harvey
> > > wrote:
> > > > The attached patch is a slightly cleaned up
> > > version of  a patch several
> > > > people have been using with recent ivtv drivers.
> > > <snip>
> > >
> > > Any reason why the existing region code wasn't used
> > > more directly?  Seems
> > > you're duplicating logic..
> > >
> > > Isaac
> > > _______________________________________________
> > > mythtv-dev mailing list
> > > mythtv-dev at mythtv.org
> > >
> > http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev
> > >
> > _______________________________________________
> > mythtv-dev mailing list
> > mythtv-dev at mythtv.org
> > http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev