[mythtv] minor bug in autoexpire.cpp

Daniel Kristjansson danielk at cuymedia.net
Mon Aug 15 17:13:46 UTC 2005


On Mon, 2005-08-15 at 12:06 -0400, Preston Crow wrote:
> On Sun, 2005-08-14 at 22:11 -0400, Daniel Kristjansson wrote:
> > On Sun, 2005-08-14 at 13:46 -0400, Preston Crow wrote:
> > > I've been looking at the verbose output of the logging, and I see a
> > > bunch of messages like:
> ...
> > > BTW: Should I be writing and submitting a patch?  If so, what's the
> > > procedure for submitting it?
> ...
> > Then, after saving that, attach the patch. You can go ahead and assign
> > this to me. Then I'll look at it and either commit or explain why I
> > haven't.
> 
> Ticket #219.  This is my first patch to this project, so please point
> out anything that I should have done differently for next time.

It looks like the DB query is failing for some reason. I've changed the
code so that it prints a more informative message on failure.

As for patches, it is better that you don't do the diff from within a
subdirectory other than a project directory, as that requires me to
know where to find the file[s] being patched. Also try to make the
change as compact as possible so that it is easier to see what is
actually changing.

-- Daniel



More information about the mythtv-dev mailing list