[mythtv] Re: [mythtv-commits] mythtv commits

[Robert Tsai]

On Fri, Apr 08, 2005 at 01:35:39PM -0400, Daniel Kristjansson wrote:
> On Fri, 2005-04-08 at 09:07 -0400, Robert Tsai wrote:
> > non-XRANDR builds are broken. My simple patch is below:
> > 
> > +#if defined(USING_XRANDR) || defined(CONFIG_DARWIN)
> >      const vector<DisplayResScreen> scr = GetVideoModes();
> >      if (scr.size())
> >          addChild(new VideoModeSettings());
> > +#endif /* USING_XRANDR || CONFIG_DARWIN */
> Can you give me the output of the gcc instantiation that fails?
> GetVideoModes() should work whether you have DisplayRes support
> or not.

The compile issue is with the VideoModeSettings (which is protected by
#ifdef), not the call to GetVideoModes. I patched around GetVideoModes
just because "scr" was otherwise unused (AFAICT).

Anyway:

g++ -c -pipe -march=k8 -Wall -W -O3 -Wall -Wno-switch \
	-fomit-frame-pointer -D_REENTRANT  -DMMX -DUSING_OPENGL_VSYNC \
	-D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -DPREFIX=\"/usr/local\" \
	-DQT_NO_DEBUG -DQT_THREAD_SUPPORT -DQT_SHARED \
	-I/usr/share/qt3/mkspecs/default \
	-I. -I../.. -I../../libs/libmythtv -I../../libs \
	-I../../libs/libmyth -I/usr/local/include -I/usr/include/qt3 \
	-o globalsettings.o globalsettings.cpp
globalsettings.cpp: In constructor `AppearanceSettings::AppearanceSettings()':
globalsettings.cpp:2994: error: `VideoModeSettings' has not been declared
make: *** [globalsettings.o] Error 1


--Rob