[mythtv] commercial-flagging "413% Completed" (new "immediate" flagging feature)

[Robert Tsai]

I enabled the new "start commercial flagging immediately after
recording" feature in mythtv-setup for the first time this evening.

There is some kind of bug with the completion calculations:

mysql> select starttime,inserttime,type,cmds,flags,status,statustime,comment from jobqueue;
+---------------------+---------------------+------+------+-------+--------+----------------+-------------------------------+
| starttime           | inserttime          | type | cmds | flags | status | statustime     | comment                       |
+---------------------+---------------------+------+------+-------+--------+----------------+-------------------------------+
| 2005-04-03 17:30:00 | 2005-04-03 18:00:00 |    2 |    0 |     0 |    272 | 20050403184654 | Finished, 4 break(s) found.   |
| 2005-04-04 21:00:00 | 2005-04-04 21:00:03 |    2 |    0 |     2 |      4 | 20050404221108 | 413% Completed @ 31.3236 fps. |
| 2005-04-03 00:00:00 | 2005-04-03 01:00:00 |    2 |    0 |     0 |    272 | 20050403030405 | Finished, 6 break(s) found.   |
| 2005-04-03 21:02:00 | 2005-04-04 00:26:26 |    2 |    0 |     0 |    272 | 20050404015807 | Finished, 11 break(s) found.  |
| 2005-04-02 18:00:00 | 2005-04-02 18:30:00 |    2 |    4 |     0 |    288 | 20050402192222 | Job aborted by user.          |
+---------------------+---------------------+------+------+-------+--------+----------------+-------------------------------+
5 rows in set (0.00 sec)

Note the entry that claims "413% Completed".

The percentage is computed in NuppelVideoPlayer.cpp:

            if (totalFrames)
                percentage = currentFrame->frameNumber * 100 / totalFrames;
            else
                percentage = 0;

I am guessing that maybe this "immediate" starting of commercial
flagging is throwing off the correct value for "totalFrames" (although
I still can't think of how you'd achieve a >100% value)?

I don't know when this will finish. Typically, the post-recording
commercial flagging finishes in about 66% real-time (e.g., 40 minutes
to flag a 60-minute show).

It's not finished yet, so I don't know how the actual flagging has
been affected (in terms of correctness). FWIW, the show is FOX "24".

--Rob