[mythtv] [PATCH] Mac OS X patch 29
Nigel Pearson
nigel at ind.tansu.com.au
Tue Sep 7 03:32:27 EDT 2004
>> Or, is it the excessive whitespace I add to if expressions?
>
> Excessive whitespace. Just look at the existing code you're modifying.
OK. 'Tis now compressed to "if (!ReadBlah())"
> You also left out the header part of the patch,
Do'h. Was rushing to try and get it in 0.16 :-)
Guess PPC users will have to wait for 0.17 now, though.
> and it'd also probably be a good idea to have those helpers inlined.
I can't easily make them inlined functions, because
they use ringBuffer->Read() and thus need to be in the
decoder class hierarchy. (only workaround I could think
of was to store the pointer to the method (vtbl entry).
Too ugly. Unless there is some other way?
I have made them private inline methods, but I think
most compilers just ignore the inline in that situation.
Others with a better knowledge of C++ may know the deal.
Have tested compilation on 0.15 and CVS, but I don't
have a Nuppel stream backend handy today for full testing.
cvs diff -u settings.pro libs/libmythtv/nuppeldecoder.*
>../patch.macosx.30
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.macosx.30
Type: application/octet-stream
Size: 10716 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20040907/59c62b1f/patch.macosx.obj
-------------- next part --------------
P.S. I would _like_ to have the backend record its endianness
in one of the structures. Something like:
format.h
typedef struct rtfileheader
{
char finfo[12]; // "NuppelVideo" + \0
char version[5]; // "0.05" + \0
+ char isBigEndian; // Anything but \0 means true
+ char expansion[2];
int width;
Does that seem sensible? If so, then we could eliminate
the whole SWAP_ENDIAN business from settings.pro, and just
have nuppeldecoder check that bool (er, char).
--
Nigel Pearson, nigel at ind.tansu.com.au | "Reality is that which,
Telstra BI&D, Sydney, Australia | when you stop believing
Office: 8255 4222 Fax: 8255 3153 | in it, doesn't go away."
Mobile: 0408 664435 Home: 9792 6998 | Philip K. Dick - 'Valis'
More information about the mythtv-dev
mailing list