[mythtv] [PATCH] Mac OS X patch 29

[Isaac Richards]

On Tuesday 07 September 2004 12:31 am, Nigel Pearson wrote:
> > Please fix the indentation style and resubmit - ie, no stuff like:
> >
> > +            if ( ! ReadFrameheader(&frameheader) )
>
>  But, that _IS_ my indentation style :-(

But it's nothing like the prevalent the style in myth.  Mixing indentation 
styles leads to completely unreadable and unmaintainable code.

>  Or, is it the excessive whitespace I add to if expressions?

Excessive whitespace. Just look at the existing code you're modifying.  You 
also left out the header part of the patch, and it'd also probably be a good 
idea to have those helpers inlined.

Isaac