[mythtv] [PATCH] Big audio update redux
Ed Wildgoose
lists at wildgooses.com
Mon Oct 11 10:54:48 UTC 2004
Ed Wildgoose wrote:
>
>> Basically tv_play can't access the volume control because it is part
>> of the AudioOutput class and NuppleVideoPlayer has that as a
>> private. I know I can fix it, but don't have time right now to make
>> sure that I do it the correct C++ way :-) .
>
>
>
> I have just had a quick look at your volume control code. I suspect
> that the best way to fix this is not to make the audiooutput class
> puiblic, but to add some stub functions to the nuppelvideo class which
> just call through to the audio class.
Hi, Thanks for the volume control stuff. I think we need to think
multichannel and break out the interface a little. Could you please
revisit this patch with the following changes:
- Move the interface functions in AudioOutputBase into AudioOutput (so
they have to be implemented everywhere).
- AudioOutput functions should be simply: "SetVolume(int channel, int
volume)", "SetVolumeAll(int volume)", and "GetVolume(int channel, int
volume)". Everything else is implemented using those
- Keep the volumecontrol.h/.cpp and do all the clever stuff here. Make
this class inherited by NuppelVideo or whatever it is, so that the
functionality is exposed as public functions that are available to the
frontend player application. Now we can implement our invert muted
channels code and stuff like this here. However, make the setvolume
calls use the SetVolumeAll code and this way a multichannel output will
also be controlled in the same way
I have a patch with all the other stuff apart from this in, and just
testing it now. Will submit for CVS shortly
Thanks everyone
Ed W
More information about the mythtv-dev
mailing list