[mythtv] Patch: Latest Audio Patch

Isaac Richards ijr at po.cwru.edu
Thu Nov 11 07:38:08 UTC 2004

On Wednesday 10 November 2004 03:25 am, Ed Wildgoose wrote:
> David George wrote:
> > On 11/09/2004 09:32 AM, Ed Wildgoose wrote:
> >> [David I reverted one small part of your patch which tried to do
> >> something clever with the "volume_multiplier" in the volume_base.cpp
> >> code.  I think this should live in audiooutputalsa.cpp if you still
> >> want it?]
> >
> > I just finished testing this latest patch against CVS as of this
> > evening and everything looks/sounds good here.  Using an Intel ICH4
> > with Alsa 1.0.7rc2 (don't have much time right now to test other Alsa
> > versions).
> >
> > Also, it would appear that the volume_range_multiplier I had in
> > AdjustCurrentVolume may no longer be needed.  No matter what I tried I
> > couldn't make it get stuck on a certain volume.  It behaved exactly as
> > it should.
> Great news.  Well, this is just cursory testing of course, but at least
> it's good to hear that it applies and compiles cleanly against CVS.  I
> think this means that patch is now good to go
> Could we please get this committed to CVS now?

It's all in.  I changed some stuff in tv_play.cpp (mainly, activenvp -> nvp 
since what you had wouldn't work right on PiP), though..


More information about the mythtv-dev mailing list