[mythtv] [PATCH] GetNextProgram for a channel without programme info

Steven mythmail at richardstraat.homedns.org
Wed Nov 3 20:49:18 UTC 2004


Op vr, 29-10-2004 te 14:50 +0100, schreef David Matthews:
> I have a number of radio channels in my setup for which there is no 
> programme information available.  When I changed to the channel the 
> on-screen display showed the correct information but if I used the 
> channel browser the programme length was a large negative number and 
> the channel callsign was missing.  It turned out that 
> TVRec::GetNextProgram wasn't handling the case of failing to get 
> programme information from the database in the same way as 
> GetChannelInfo.  This patch fixes GetNextProgram so that it works in 
> the same way.
> 
> This is the first time I've submitted a patch so let me know if using a 
> different format or procedure would make things easier in the future.
> David.

Your patch made me have a look at a problem I've been seeing with the
OSD browser. If I browse trough a channel that doesn't have anything on
at the moment it still shows the previous program that was on. It would
be nicer it would show "no transmission" or even the "UnknownTitle"
value from the settings table that is also shown in the guide.
I am no programmer but I think the code currently just shows the last
program that was on. Another check should be added to see if the prev.
program is't over at the time of browsing. I've added something like
this to your patch (the first two lines) but since my C knowledge is
close to nonexisting it is a very dirty hack. But it should be an easy
fix for someone who actually knows what he's doing and that's why I post
it anyway.

Steven


-------------- next part --------------
A non-text attachment was scrubbed...
Name: osd_browser.patch
Type: text/x-patch
Size: 2553 bytes
Desc: not available
Url : http://mythtv.org/pipermail/mythtv-dev/attachments/20041103/a59694c7/osd_browser.bin


More information about the mythtv-dev mailing list