[mythtv] [PATCH] Display Resolution Override V2a
ijr at po.cwru.edu
Fri Jul 23 16:32:09 EDT 2004
On Friday 23 July 2004 04:13 pm, John Patrick Poet wrote:
> On Fri, 23 Jul 2004, Isaac Richards wrote:
> > On Sunday 18 July 2004 04:12 pm, John Patrick Poet wrote:
> > > This is a minor update to my DisplayRes patch. I did not want to have
> > > a global instance of the DisplayRes class in mythfrontend, but it turns
> > > out there is no choice. Without it, changing the GUI display
> > > resolution would not *completely* take effect until mythfrontend was
> > > shutdown and restarted -- not something most people want to do.
> > >
> > > This version of the "Display Resolution Override" patch seems to be
> > > very robust. I have been using/testing it for a long time now. I
> > > don't believe that any of the "core" Myth developers have a HDTV, so I
> > > realize it is hard to validate this patch, but I believe it is safe to
> > > include it in the CVS.
> > I don't see why this patch has to be so intrusive, with ifdefs scattered
> > everywhere. Why can't it be completely localized to the output method?
> > Isaac
> The way it is currently implemented, it make library calls to xander, which
> is only available in newer version of XFree and Xorg. It would be easy to
> change it back to using a system call, but that noticeably slows down
> channel changes - when the video size changes.
That's not what I'm talking about.
> P.S. When you say "localized to the output method", are you suggesting
> that it should be completely contained within the videooutput_* code? If
> so, I am not sure how that could be pulled off efficiently.
A separate class only used in the videooutput_* code, yes. All you're doing
is changing resolutions when it starts displaying, when it stops displaying,
and when the guidegrid stuff is called, and those are already going through
the videoutout_ classes.
More information about the mythtv-dev