[mythtv] [PATCH] Display Resolution Override V2a
John Patrick Poet
john at BlueSkyTours.com
Fri Jul 23 16:13:05 EDT 2004
On Fri, 23 Jul 2004, Isaac Richards wrote:
> On Sunday 18 July 2004 04:12 pm, John Patrick Poet wrote:
> > This is a minor update to my DisplayRes patch. I did not want to have a
> > global instance of the DisplayRes class in mythfrontend, but it turns
> > out there is no choice. Without it, changing the GUI display resolution
> > would not *completely* take effect until mythfrontend was shutdown and
> > restarted -- not something most people want to do.
> > This version of the "Display Resolution Override" patch seems to be very
> > robust. I have been using/testing it for a long time now. I don't
> > believe that any of the "core" Myth developers have a HDTV, so I realize
> > it is hard to validate this patch, but I believe it is safe to include
> > it in the CVS.
> I don't see why this patch has to be so intrusive, with ifdefs scattered
> everywhere. Why can't it be completely localized to the output method?
The way it is currently implemented, it make library calls to xander, which
is only available in newer version of XFree and Xorg. It would be easy to
change it back to using a system call, but that noticeably slows down
channel changes - when the video size changes.
I was afraid that it would not compile for someone using an older version of
X, so I decided to protect it with the USING_XRANDR define.
I would be happy to re-work it, if you would give me some direction on how
you would like it done.
P.S. When you say "localized to the output method", are you suggesting that
it should be completely contained within the videooutput_* code? If so, I
am not sure how that could be pulled off efficiently.
More information about the mythtv-dev