[mythtv] [PATCH] MythVideo cd support
J. Donavan Stanley
jdonavan at jdonavan.net
Sun Jul 11 09:03:26 EDT 2004
Xavier Hervy wrote:
> J. Donavan Stanley wrote:
>> Xavier Hervy wrote:
>>> I send the last version of my patch.
>> Xavier, I do plan on applying this to my tree this weekend and seeing
>> about getting it in.
> Ok, thx.
> Hope it look good for you
Much as I hate to do this:
Can you please break your patches up into logical chunks that accomplish
smaller tasks? You're changing so much with one patch it's a bit
difficult to track everything and I'm not comfortable with just applying
it and saying "it seems to work".
A good place to start is the support for data CDs. That's something
Can you explain the following:
//only register media handler if VideoAutoAddMediaToDatabase is turned on
+ // or VideoOnInsertMedia different to 0
+ //if ( gContext->GetNumSetting("VideoAutoAddMediaToDatabase",0)==1
+ // || gContext->GetNumSetting("VideoOnInsertMedia",0)!=0)
+ REG_MEDIA_HANDLER("MythVideo CD/DVD DATA Media
Is comment correct or is the code since they appear to be mutually
More information about the mythtv-dev