[mythtv] [PATCH2] OSD resize

Kristof Pelckmans kristof.pelckmans at antwerpen.be
Mon Aug 30 05:23:22 EDT 2004

Quoting Isaac Richards <ijr at po.cwru.edu>:

> On Sunday 29 August 2004 09:07 pm, Kristof Pelckmans wrote:
> > Quoting Chris Pinkham <cpinkham at bc2va.org>:
> > > Forgot to mention one other thing.  The patch doesn't appear to handle
> > > resizing the OSD menus, but it would be nice if we could get those
> > > resized as well since they go offscreen as well when zoomed.
> >
> > This patch corrects the segfault you mentioned in the previous post, irons
> > out the x and y offset wrinkles and includes support for the repositioning
> > of the OSD
> > menu.
> I don't think I like the idea of videooutbase having anything to do directly
> with the OSD, as there other resize logic currently lives in the NVP class.
> This probably should as well.
Is there a way to go from the videoout* to the NVP ? I need to pass the newly
calculated offsets to the Resize method.

> What's the reasoning behind the m_rect_off stuff in OSDListTreeType?  Those
> should be getting passed in the Draw() functions, not stored in the class.
Right !!!

> Also, what're the x/y_off_fade variables for in the OSDSet class?
Previously the xoff and yoff variables passed into the Reinit method were not
used. However, there exist a m_xoff and m_yoff, that are only used in the
following code :

    if (m_fadetime > 0)
        m_fadetime -= m_frameint;

        if (m_xmove || m_ymove)
            m_xoff_fade += (m_xmove * m_frameint * 30) / 1000000;
            m_yoff_fade += (m_ymove * m_frameint * 30) / 1000000;
            m_fadetime -= (4 * m_frameint);

Since I figured it had something to do with fade out of the osd, I renamed
those variables. However, I must admit that I don't really get what this is
for ?

> Please don't submit patches that use a different indentation style, either.
> The 'x_' style variables are pretty unreadable and ugly, too.
I completely agree, it was early this morning...


More information about the mythtv-dev mailing list