[mythtv] [PATCH2] OSD resize

Isaac Richards ijr at po.cwru.edu
Mon Aug 30 04:14:36 EDT 2004

On Sunday 29 August 2004 09:07 pm, Kristof Pelckmans wrote:
> Quoting Chris Pinkham <cpinkham at bc2va.org>:
> > Forgot to mention one other thing.  The patch doesn't appear to handle
> > resizing the OSD menus, but it would be nice if we could get those
> > resized as well since they go offscreen as well when zoomed.
> This patch corrects the segfault you mentioned in the previous post, irons
> out the x and y offset wrinkles and includes support for the repositioning
> of the OSD
> menu.

I don't think I like the idea of videooutbase having anything to do directly 
with the OSD, as there other resize logic currently lives in the NVP class.  
This probably should as well.

What's the reasoning behind the m_rect_off stuff in OSDListTreeType?  Those 
should be getting passed in the Draw() functions, not stored in the class.  
Also, what're the x/y_off_fade variables for in the OSDSet class?  

Please don't submit patches that use a different indentation style, either.  
The 'x_' style variables are pretty unreadable and ugly, too.


More information about the mythtv-dev mailing list