[Small PATCH as Req] + Re: [mythtv] frequent PlayBoxTransparency setting DB lookup in mythvideo

J. Donavan Stanley jdonavan at jdonavan.net
Tue Aug 17 21:22:30 EDT 2004

Colin Guthrie wrote:

> J. Donavan Stanley wrote:
>> Things should be MUCH better now with what I just checked in.

Thanks for resubmitting this I'll take a look at it in the AM.

> FYI, I'm not sure if it is in any way related, but the interlacing of 
> the screen in the Video Manager when doing an IMDB lookup seems to be 
> very slow now...

I've not mucked with the videomanager's base class / drawing...

> Oh, for what it's worth, I remembered why we use an explicit check for 
> 1 row at work.... it's because we often work on each others files etc. 
> in the team and it makes the code a lot clearer to people when working 
> on files you didn't write yourself that the author expects *exactly* 
> one row from that query. Not a big deal really, it's just for overall 
> clarity.

I don't personally have a problem with it.  Though I think most of the 
Myth code uses >0 as a convention.  I was more curious as to the 
reasoning behind it.  Clarity is reason enough. ;)

More information about the mythtv-dev mailing list