[mythtv] [PATCH] Allow channel changes across inputs on the same
bjm at lvcm.com
Sun Apr 18 19:25:36 EDT 2004
Matt Zimmerman wrote:
> On Sat, Apr 17, 2004 at 09:32:08AM -0400, J. Donavan Stanley wrote:
>>This patch allows for channel changes across inputs on the same card.
>>Currently one needs to change the input first than change the channel.
>>With this patch, if the initial query in checkChannel fails it will
>>widen it's search to include other inputs on the same card. If that
>>check succeeds then setChannelByString will use
>>ChanelBase::SwitchToInput and return.
>>Now that combining my sat and antenna feeds is easier I need to find a
>>better indoor antenna...
> I was just thinking about this yesterday. Unfortunately, I don't have a way
> to test it. It looks reasonable, though.
Okay, so I tested it ;-) and it does generally work. A few
things didn't that should be expected but there's one thing
that really should have.
I tested this with two cards. Analog cable on both and digital
on s-video of the second card so the S/I/Cs are 1/1/1, 1/2/2
and 2/3/2 with input 3 being the digital cable.
Entering a channel number or choosing a channel from the EPG
during LiveTV worked. However, I would get two "Found channel
on another input" messages per input change. Is this because it
has two other inputs to check? It might also be a good idea to
include another verbose message to show the card and input as
this may help with debugging user issues down the line.
Browse mode doesn't include the channels from inputs other than
the current. I believe Chris had done this deliberately because
it couldn't go to those other channels. This is fine for now
and could be changed later.
The up and down arrows do not change to the other input. Up
from the highest channel on input 1 does not go to the other
input but to the lowest channel on input 1. That's fine. It may
even make sense to leave it that way.
Here is a problem though. I started a recording on card 1 them
went to LiveTV on card 2 which has both sources. While I was
on 1/2/2 and typed in a channel for 2/3/2, it did not change.
It did nothing just as if an incorrect channel number had been
entered. Same for choosing a digital channel from the EPG.
PIP channel swapping of course didn't work but that would be
another issue for another time.
More information about the mythtv-dev