[mythtv] 4:3 Zoom code changed?

[Edward Wildgoose]

> > I think someone changed the 4:3 zoom code recently?  The behaviour
> > seems to have changed anyway.
> 
> Yeah, that was me.
> 
> Previously, the code was useless on 16:9 sets, which is why I changed  
> it.  Currently the three modes are:
> * 4:3: fullscreen on 4:3 set, pillarboxed (shrink in X) on 16:9 set
> * 16:9: letterboxed (shrink in Y) on 4:3 set, fullscreen on 16:9 set
> * Zoom: Zoom (grow both X and Y) by 4/3

Yep, It's the last which is causing me trouble.  A thought occurs.  You didn't expand by 4/3 instead of 3/4 did you?

> The first two change the aspect ratio, the third maintains it while  
> scaling.  This third one should be what you want.  At least that's the  
> intent.  Is this not what you're seeing?  What's the aspect ratio of  
> your TV, the entire video, and the active portion of the video; and the  
> pixel dimensions for all three?

Basically I have a 4:3 telly, but the BBC insist on broadcasting everything in 16:9, but when it actually is a 4:3 broadcast then the 16:9 picture has black bars down the left and right (as well as the letterbox  ones on the top, ie black border all around)

 __________
 |  ____  |
 |  |___| |
 |________|

However, when I use the zoom mode then the screen is expanded left/right to fit the picture, but the height is expanded by significantly more than a proportionate resize and the top/bottom are cut off, and people become tall and thin.

Does that make sense?


> Note that the other change is that playback now pays attention to your  
> set's aspect ratio as defined by its dimensions in your XF86Config  
> file, so if those are set incorrectly it could confuse the issue.

Nope, this isn't set at all in my config, so I think it defaults to something sensible...?