[mythtv] First patch for runtime configurable keybindings

Erik Arendse erik_nospam.arendse at bigfoot.com
Wed Mar 5 08:46:13 EST 2003


At 3-3-03 16:39, Isaac Richards wrote:
>That's how it should work -- the player should select the output method, the
>output method shouldn't select itself.

Then we agree we disagree. But as you control the source... ;-)
I think it is ugly when I for instance want to add hardware MPEG out 
support I would not only have to modify the videooutput class, but also add 
a test for the output wanted to the player and let it choose what subclass 
to instantiate. Why would the player need to know if the output is going 
via XV, framebuffer or hardware MPEG? The output class should hide all the 
gory implementation details from the player.

> > With all the above there is no need to add the keymap to the context,
> > although I agree it 'feels' better.
>
>Just the keymap object, all the init stuff can stay in the separate modules.
>For most of the rest of the UI, one global keymap can be used (arrow keys and
>a couple additional keybindings).

OK. Indeed I wanted a single menu-context to this end.

> > Do you have any thoughts about PIP support?
>
>I don't see why it would be broken.  The PiP stuff is called with disable
>video enabled, and I don't recall any of your changes being in that path.

I must have a look into the PIP support then, I presumed it would be an XV 
overlay on top of anotherer XV overlay. I presume now you insert the 
picture data yourself in the master-video like the OSD.

Erik



More information about the mythtv-dev mailing list