[mythtv] [PATCH/APP] Program rankings

Isaac Richards ijr at po.cwru.edu
Sat Jun 28 20:18:31 EDT 2003


On Saturday 28 June 2003 03:03 pm, Jason Rosson wrote:
> Here's a patch plus a tarball of additional files needed to
> use ranking to do conflict resolution.  It can be set to run
> before or after the existing conflict resolution or not at
> all.  There are three levels of rankings: program, channel and
> recording type.  All three add up to the final rank value and
> are used in mythbackend/scheduler.cpp between two programs that
> conflict.
>
> The program ranking is done under Schedule Recordings and the
> other two are under Setup/TV Settings/Rankings.  I've been using
> it for a few days and haven't had any problems (or conflicts)
> and just synced it with the current CVS.

Very nicely done.  Just what I like, a big patch that applies cleanly =)  I've 
just committed it to CVS with a few minor modifications -- I added support 
for the weekslot recording type, and made it possible to go to the recording 
type screen from the program rankings screen.  Also made it pop up a dialog 
to give an error on themes that don't support it.

I am sort of worried about the efficiency of the CheckRank() function.  
That'll be doing a _lot_ of duplicate database hits to grab the type and 
channel ranks -- could those be cached somewhere instead?

Just noticed a bug in the program rankings screen (probably also in the 
channel rankings).  If you change a value enough that it has to resort, the 
list highlight disappears.

Isaac


More information about the mythtv-dev mailing list