[mythtv] [PATCH] MP3 options for TV recording
dave2 at wetstring.net
Thu Dec 4 18:47:22 EST 2003
-----BEGIN PGP SIGNED MESSAGE-----
On Thu, 4 Dec 2003, Matt Zimmerman wrote:
> On Fri, Dec 05, 2003 at 11:35:35AM +1300, David Zanetti wrote:
> > Changes:
> > - Renames "MP3 Quality" to "Algorithm Quality", reflecting what the
> > control actually does. Help text updated to suit.
> This control does not affect the quality of the algorithm. It should
> probably be renamed "Quality", regardless of what the underlying setting is
Odd, because that's exactly how the function is described in lame.h:
internal algorithm selection. True quality is determined by the bitrate
but this variable will effect quality by selecting expensive or cheap
quality=0..9. 0=best (very slow). 9=worst.
recommended: 2 near-best quality, not too slow
5 good quality, fast
7 ok quality, really fast
int CDECL lame_set_quality(lame_global_flags *, int);
.. and that's what the mp3quality setting calls even before this patch. I
note the command-line lame has the same descriptions of the option.
> > - Adds CBR/ABR/VBR option
> Have you checked whether this actually works properly? I thought there was
> a reason why things were the way they were.
I posted to the list a few days ago asking about that myself, but didn't
get a response. However, works for me with least CBR (have done a few
hours of recordings with it already), and briefly tested VBR and ABR using
live tv just to check it got some audio.
I'll run a few hours of recordings in ABR/VBR modes just to check there's
no drift and it works as expected.
> > - Adds bitrate option (for CBR/ABR)
> > - Adds quality slider (for VBR)
> > - Adds stereo mode (auto, joint stereo, stereo, mono downmix)
> Rather than having comments like "Ignored if...", it would be better to have
> only applicable options displayed depending on the value of the CBR/ABR/VBR
> option. See the codec selector, some of the audio settings, etc. for
> examples of how to do this.
Aye, I shall do that and resubmit.
David Zanetti | (__)
#include <geek/unix.h> | ( oo Mooooooo
http://hairy.geek.nz/ | /(_O ./
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: Made with pgp4pine 1.75-6
-----END PGP SIGNATURE-----
More information about the mythtv-dev