[mythtv] DVB Code Update

Kenneth Aafloy ke-aa at frisurf.no
Wed Aug 27 09:45:30 EDT 2003


Ben Bucksch wrote:

> Ben Bucksch wrote:
> 
> > That's a lot better than the earlier versions. A few comments (I 
> > haven't read through all the code):
> 
> I just saw that you unnecessarily dropped support for use_ts = 1 (filter 
> PIDs in MythTV). It may have had a bug, but it's still an important mode 
> for later when we support multiple recordings per card, and it was a 
> design goal when I wrote the code. Current cards/drivers can only filter 
> a limited number of PIDs, which is likely not to be sufficient for 
> multiple recordings.
> 
> If you knowingly break features in your patches, you should warn about 
> that clearly.

Fixed!

> You dragged ts_to_ps into dvbrecorder.cpp. If you copy code from 
> elsewhere (even when with changes), please add a comment (right above 
> the copied/adapted code) where it comes from. It gives credit and helps 
> keeping the code in sync in case of bugs.

Added note at the top, sorry for forgetting.

Kenneth



--------------------------------------------------------------------------------


_______________________________________________
mythtv-dev mailing list
mythtv-dev at mythtv.org
http://mythtv.org/cgi-bin/mailman/listinfo/mythtv-dev



More information about the mythtv-dev mailing list