[mythtv] DVB Code Update

Ben Bucksch linux.news at bucksch.org
Wed Aug 27 09:09:41 EDT 2003

Ben Bucksch wrote:

> That's a lot better than the earlier versions. A few comments (I 
> haven't read through all the code):

I just saw that you unnecessarily dropped support for use_ts = 1 (filter 
PIDs in MythTV). It may have had a bug, but it's still an important mode 
for later when we support multiple recordings per card, and it was a 
design goal when I wrote the code. Current cards/drivers can only filter 
a limited number of PIDs, which is likely not to be sufficient for 
multiple recordings.

If you knowingly break features in your patches, you should warn about 
that clearly.

You dragged ts_to_ps into dvbrecorder.cpp. If you copy code from 
elsewhere (even when with changes), please add a comment (right above 
the copied/adapted code) where it comes from. It gives credit and helps 
keeping the code in sync in case of bugs.

More information about the mythtv-dev mailing list