[mythtv] Re: DVB-C recording bug

Georg C. F. Greve greve at gnu.org
Tue Aug 19 12:57:18 EDT 2003

 || On Tue, 19 Aug 2003 00:16:29 +0200
 || Ben Bucksch <linux.news at bucksch.org> wrote: 

 bb> I'll send another patch later when I have time, try Kenneth's
 bb> patch in the meantime, if you want, it should fix your problem
 bb> just as well (only code style and error checking differences).

Well. That unfortunately also doesn't compile:

g++ -c -pipe -Wall -W -O3 -march=pentiumpro -fomit-frame-pointer `freetype-config --cflags` -D_REENTRANT  -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -DPREFIX=\"/usr\" -DMMX -DUSING_DVB -DQT_NO_DEBUG -DQT_THREAD_SUPPORT -I/usr/share/qt3//mkspecs/default -I. -I../../../../include -I../../../../local/include -I../../../../include/linux/dvb -I../libmyth -I.. -I../libavcodec -I../libavformat -I../libdvbdev -I/usr/share/qt3//include -o dvbchannel.o dvbchannel.cpp
dvbchannel.cpp: In constructor `DVBChannel::DVBChannel(TVRec*, int, bool, char)
dvbchannel.cpp:41: error: returning a value from a constructor
dvbchannel.cpp: In function `bool DVBTune(const DVBTunerSettings&, int)':
dvbchannel.cpp:436: error: `fd_frontend' undeclared (first use this function)
dvbchannel.cpp:436: error: (Each undeclared identifier is reported only once 
   for each function it appears in.)
dvbchannel.cpp:436: error: `fd_sec' undeclared (first use this function)
dvbchannel.cpp:434: warning: unused parameter `int cardnum'
make[2]: *** [dvbchannel.o] Error 1
make[2]: Leaving directory `/usr/src/mythtv-0.11/libs/libmythtv'
make[1]: *** [sub-libmythtv] Error 2
make[1]: Leaving directory `/usr/src/mythtv-0.11/libs'
make: *** [sub-libs] Error 2

Which shows the problem with returning -1 from a constructor you
mentioned before, I believe, and again the possible namespace
problem (line 436).

Since fd_frontend and fd_sec are defined as parts of the DVBChannel
class, using them without further specification in global namespace
(which the DVBTune function is), seems responsible for the problem.

As DVBTune seems to be one of the few functions in that file that are
not part of DVBChannel, it is easy to see how this could happen...


Georg C. F. Greve                                       <greve at gnu.org>
Free Software Foundation Europe	                 (http://fsfeurope.org)
Brave GNU World	                           (http://brave-gnu-world.org)

More information about the mythtv-dev mailing list