[mythtv] [PATCH] use presets instead of channums
bjorn at hijmans.nl
Fri Apr 25 16:53:13 EDT 2003
On Fri, 25 Apr 2003, Isaac Richards wrote:
> > Attached a patch to use presets instead of channelnumbers to change
> > insert into settings (value, data, hostname) values ('HideChannum', 1,
> > '<yourhost>');
> Why not use the existing settings value for this? If it's sorting by chanid,
> might as well use that bit to enable things.
Good idea, I'll change this.
> > channels using mythfilldatabase --xawchannels) the chanid starts with
> > 1000. So, the preset is the chanid - 999.
> It'd be _much_ better to have this detected automatically from the current
> channel source, instead of hardcoding a value that's not going to work for
Also a good idea, I'll change that as well.
> > I know the implementation isnt very decent. But, to do it the right way, I
> > should add an extra column in the channels table. This would require
> > rewriting a lot of code (especially because in the majority of the methods
> > the channum instead of the chanid is used to refer to a record in the
> > channels table).
> So, do that instead.
I wont because I think with the current databasedesign it will always stay
a hack. I think the changes Ben proposed are better. If these changes are
implemented mythtv is internaly no longer working with the channum (but
with the chanid, as it should) and we can easily add an extra column (or
reuse the existing channum column) for the preset.
I will change the other points though.
More information about the mythtv-dev