[mythtv] [PATCH] use presets instead of channums

Isaac Richards ijr at po.cwru.edu
Fri Apr 25 10:25:14 EDT 2003

On Thursday 24 April 2003 03:40 pm, Bjorn Hijmans wrote:
> Hi,
> Attached a patch to use presets instead of channelnumbers to change
> channels. The preset will be printed in the OSD as well. Execute the
> following query to enable this (you cant change this in the setup):
> insert into settings (value, data, hostname) values ('HideChannum', 1,
> '<yourhost>');

Why not use the existing settings value for this?  If it's sorting by chanid, 
might as well use that bit to enable things.

> The preset is derived from the chanid. I order my channels using the
> chanid. Also, in my database (and probably others that have loaded their
> channels using mythfilldatabase --xawchannels) the chanid starts with
> 1000. So, the preset is the chanid - 999.

It'd be _much_ better to have this detected automatically from the current 
channel source, instead of hardcoding a value that's not going to work for 

> I know the implementation isnt very decent. But, to do it the right way, I
> should add an extra column in the channels table. This would require
> rewriting a lot of code (especially because in the majority of the methods
> the channum instead of the chanid is used to refer to a record in the
> channels table).

So, do that instead.


More information about the mythtv-dev mailing list