[mythtv] buglet in cvs?

Grant Taylor mythtv-dev@snowman.net
Fri, 13 Sep 2002 23:39:08 -0400


>> hang in confusion when you select the missing-file entry.
> Does what I just committed fix that?

Undoubtedly!  Reminds me why I prefer printf-alikes: the compiler will
parse the string and check argument counts, types, etc...

Unfortunately I erased all my recordings by hand just now as part of
switching back from 32000 to 44100 khz audio, so now I have nothing to
delete and check :(

Oh, below are my local changes, one or two of which you might want to
adopt or not.  They implement:

 - Larger fonts in several places I wanted them.  It's not a setting,
   just a different hard-coded font here and there.  The time format
   in the listbox is also changed to go with this.  And in one place
   the font scaling calculation broke for skinny non-square sizes.

 - The delete and playbox show the oldest or newest recordings first
   as appropriate.  Before it was apparently sorting on either channel
   or date as a string, neither of which worked quite right.  I guess
   you could mouse around the dialog and change the sorting, but best
   for it to just do what I want ;)



Index: libNuppelVideo/osd.cpp
===================================================================
RCS file: /var/lib/cvs/MC/libNuppelVideo/osd.cpp,v
retrieving revision 1.20
diff -u -r1.20 osd.cpp
--- libNuppelVideo/osd.cpp	18 Aug 2002 19:16:01 -0000	1.20
+++ libNuppelVideo/osd.cpp	14 Sep 2002 03:30:01 -0000
@@ -130,7 +130,7 @@
         usingtheme = LoadTheme();
     }
 
-    if (vid_width < 400 || vid_height < 400)
+    if (vid_height < 400)
     {
         infofontsize /= 2;
         channumfontsize /= 2;
@@ -201,7 +201,7 @@
     dialogRect.setLeft(vid_width / 8);
     dialogRect.setRight(vid_width * 7 / 8);
 
-    infofontsize = 16;
+    infofontsize = 18;
     channumfontsize = 40;
 
     usepause = false;
Index: mythepg/guidegrid.cpp
===================================================================
RCS file: /var/lib/cvs/MC/mythepg/guidegrid.cpp,v
retrieving revision 1.25
diff -u -r1.25 guidegrid.cpp
--- mythepg/guidegrid.cpp	4 Sep 2002 06:53:54 -0000	1.25
+++ mythepg/guidegrid.cpp	14 Sep 2002 03:30:02 -0000
@@ -39,8 +39,8 @@
     setCursor(QCursor(Qt::BlankCursor));
 
     setPalette(QPalette(QColor(250, 250, 250)));
-    m_font = new QFont("Arial", 11 * hmult, QFont::Bold);
-    m_largerFont = new QFont("Arial", 13 * hmult, QFont::Bold);
+    m_font = new QFont("Arial", 18 * hmult, QFont::Bold);
+    m_largerFont = new QFont("Arial", 20 * hmult, QFont::Bold);
 
     m_originalStartTime = QDateTime::currentDateTime();
     m_currentStartTime = m_originalStartTime;
Index: mythfrontend/deletebox.cpp
===================================================================
RCS file: /var/lib/cvs/MC/mythfrontend/deletebox.cpp,v
retrieving revision 1.15
diff -u -r1.15 deletebox.cpp
--- mythfrontend/deletebox.cpp	14 Sep 2002 03:10:58 -0000	1.15
+++ mythfrontend/deletebox.cpp	14 Sep 2002 03:30:02 -0000
@@ -74,7 +74,7 @@
     listview->setColumnWidth(2, 435 * wmult);
     listview->setColumnWidth(3, 90 * wmult);
 
-    listview->setSorting(1, false);
+    listview->setSorting(-1, false);
     listview->setAllColumnsShowFocus(TRUE);
 
     connect(listview, SIGNAL(returnPressed(QListViewItem *)), this,
@@ -91,7 +91,7 @@
     ProgramListItem *item;
     
     thequery = "SELECT channum,starttime,endtime,title,subtitle,description "
-               "FROM recorded;";
+               "FROM recorded ORDER BY starttime DESC;";
 
     query = db->exec(thequery);
 
Index: mythfrontend/playbackbox.cpp
===================================================================
RCS file: /var/lib/cvs/MC/mythfrontend/playbackbox.cpp,v
retrieving revision 1.13
diff -u -r1.13 playbackbox.cpp
--- mythfrontend/playbackbox.cpp	4 Sep 2002 06:53:54 -0000	1.13
+++ mythfrontend/playbackbox.cpp	14 Sep 2002 03:30:02 -0000
@@ -48,7 +48,7 @@
     setGeometry(0, 0, screenwidth, screenheight);
     setFixedSize(QSize(screenwidth, screenheight));
 
-    setFont(QFont("Arial", 16 * hmult, QFont::Bold));
+    setFont(QFont("Arial", 20 * hmult, QFont::Bold));
     setCursor(QCursor(Qt::BlankCursor));
 
     QVBoxLayout *vbox = new QVBoxLayout(this, 20 * wmult);
@@ -67,7 +67,7 @@
     listview->setColumnWidthMode(0, QListView::Manual);
     listview->setColumnWidthMode(1, QListView::Manual);
 
-    listview->setSorting(1, false);
+    listview->setSorting(-1, false);
     listview->setAllColumnsShowFocus(TRUE);
 
     connect(listview, SIGNAL(returnPressed(QListViewItem *)), this,
@@ -84,7 +84,7 @@
     ProgramListItem *item;
     
     thequery = "SELECT channum,starttime,endtime,title,subtitle,description "
-               "FROM recorded;";
+               "FROM recorded ORDER BY starttime;";
     query = db->exec(thequery);
 
     if (query.isActive() && query.numRowsAffected() > 0)
Index: mythfrontend/programlistitem.cpp
===================================================================
RCS file: /var/lib/cvs/MC/mythfrontend/programlistitem.cpp,v
retrieving revision 1.11
diff -u -r1.11 programlistitem.cpp
--- mythfrontend/programlistitem.cpp	9 Aug 2002 06:48:29 -0000	1.11
+++ mythfrontend/programlistitem.cpp	14 Sep 2002 03:30:03 -0000
@@ -41,7 +41,7 @@
     pixmap = NULL;
 
     setText(0, pginfo->channum);
-    setText(1, pginfo->startts.toString("MMMM d h:mm AP"));
+    setText(1, pginfo->startts.toString("ddd MMM d h:mmap"));
     setText(2, pginfo->title);
 
     if (numcols == 4)


--
Grant Taylor - gtaylor<at>picante.com - http://www.picante.com/~gtaylor/
   Linux Printing Website and HOWTO:  http://www.linuxprinting.org/