[mythtv-commits] [MythTV/mythtv] 43e6e0: Collapse duplicated metadata grabber code into a s...

[David Hampton]

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 43e6e006e346e8f0e5a660658ec8227c17984d3b
      https://github.com/MythTV/mythtv/commit/43e6e006e346e8f0e5a660658ec8227c17984d3b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2023-11-29 (Wed, 29 Nov 2023)

  Changed paths:
    M mythtv/libs/libmythmetadata/metadatagrabber.cpp

  Log Message:
  -----------
  Collapse duplicated metadata grabber code into a single location.

This is to prevent duplicating more code when adding debugging in the
next commit.


  Commit: 7b75e1d1a3d6d68f90b797122ed31259873f4928
      https://github.com/MythTV/mythtv/commit/7b75e1d1a3d6d68f90b797122ed31259873f4928
  Author: David Hampton <mythtv at love2code.net>
  Date:   2023-11-29 (Wed, 29 Nov 2023)

  Changed paths:
    M mythtv/libs/libmythmetadata/metadatadownload.cpp
    M mythtv/libs/libmythmetadata/metadatagrabber.cpp

  Log Message:
  -----------
  Improve detection of invalid metadata grabbers.

1) Update GetGrabber to log a message about an invalid grabber.

2) Callers of GetGrabber now check whether a returned grabber is valid
before using it.


  Commit: e7d945cde0ca1ea5c5666cacb1973087697b4734
      https://github.com/MythTV/mythtv/commit/e7d945cde0ca1ea5c5666cacb1973087697b4734
  Author: David Hampton <mythtv at love2code.net>
  Date:   2023-11-29 (Wed, 29 Nov 2023)

  Changed paths:
    M mythtv/libs/libmythmetadata/metadatagrabber.cpp

  Log Message:
  -----------
  Text existence of metadata script directory before using.


  Commit: ddddeff184f3dbbd986bc2f74c7dbdebf124bae3
      https://github.com/MythTV/mythtv/commit/ddddeff184f3dbbd986bc2f74c7dbdebf124bae3
  Author: David Hampton <mythtv at love2code.net>
  Date:   2023-11-29 (Wed, 29 Nov 2023)

  Changed paths:
    M mythtv/libs/libmythmetadata/metadatagrabber.cpp

  Log Message:
  -----------
  Add some debugging when finding metadata scripts.

1) If the directory doesn't exist.

2) Show how many scripts were found in the directory

3) Creating a script object failed (already a message for success)


  Commit: 88ee8370f839a823eff5093ccaa746fa73aec0a6
      https://github.com/MythTV/mythtv/commit/88ee8370f839a823eff5093ccaa746fa73aec0a6
  Author: David Hampton <mythtv at love2code.net>
  Date:   2023-11-29 (Wed, 29 Nov 2023)

  Changed paths:
    M mythtv/libs/libmythmetadata/metadatagrabber.cpp

  Log Message:
  -----------
  Use the metadata grabber cache when trying to find a grabber.

The s_grabberAge variable starts in an invalid state.  The old code
didn't call the GetList() because the s_grabberAge variable was
invalid, and therefore the variable was never set to a valid value.
Remove this extra (broken) cache validity test and let the GetList
function handle whether/when it updates the cache.


  Commit: d17a46f5fa4028f0fceb0f021070dca5904b112a
      https://github.com/MythTV/mythtv/commit/d17a46f5fa4028f0fceb0f021070dca5904b112a
  Author: David Hampton <mythtv at love2code.net>
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
    M mythtv/libs/libmythmetadata/metadatadownload.cpp
    M mythtv/libs/libmythmetadata/metadatagrabber.cpp

  Log Message:
  -----------
  Add more validity checks (and some debugging) when trying to locate
the metadata grabbers.


Compare: https://github.com/MythTV/mythtv/compare/b47e464825b7...d17a46f5fa40